Search across all active variant prices #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslavtyc
force-pushed
the
search-across-all-active-variant-prices
branch
from
c50aa06 to
3ce54ad
Compare
jaroslavtyc
force-pushed
the
search-across-all-active-variant-prices
branch
from
73157d0 to
ae68509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our shops work primarily with multi-variant products.
Those variants are often priced differently each other.
And we need to search by those different-per-variant prices.
This proposal saves to Elastic all unique variant prices. Thanks to Elastic behavior that every field is an array in fact we do not need to do any other changes - no index change / rebuild, no search query changes.
My skill is insufficient to update Behat tests to test those changes, please add them by your own.